Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use opentelemetry:time::now instead of systemtime #2595

Conversation

mohammadVatandoost
Copy link
Contributor

Part 2 for #2557

@mohammadVatandoost mohammadVatandoost requested a review from a team as a code owner February 3, 2025 20:01
@mohammadVatandoost mohammadVatandoost force-pushed the otel-time-now-instead-of-systemtime branch from b62e97a to a28cf3f Compare February 3, 2025 20:03
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.3%. Comparing base (a81ad24) to head (a28cf3f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2595   +/-   ##
=====================================
  Coverage   79.3%   79.3%           
=====================================
  Files        118     118           
  Lines      22487   22487           
=====================================
  Hits       17844   17844           
  Misses      4643    4643           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Would be great if you can continue in follow up PRs to use this everywhere!

@cijothomas cijothomas merged commit 6c88d31 into open-telemetry:main Feb 3, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants